possible Bug: No default processor selected when using @Optional

[thomas-mc-work]

When my field has the annotation @Optional then no corresponding processor for the data type is selected. E.g. ParseInt is missing for all intand Integer fields. I would expect to have it created by the library, except when override it manually.

My workaround is to define the Processor manually:

@CsvField(order = 7)
@Optional(order = 0)
@ParseChar(order = 1)
private Character myValue;

[dominikschlosser]

That is not a bug but could be a possible improvement. It is implemented this way on purpose since one might use another processor than the default ones to do the conversion. The only situation where ParseXXX-annotations are added automatically is when there is no processor-annotation at all. In all other cases we would need to check the return type of the last CellProcessor which can not be done right now because of type-erasure and thus would require major changes.

Two possible solutions:

• CellProcessorFactory has to provide the return type. This is an additional source of errors as the type system can not check if the returned type is indeed the CellProcessor return type.
• Catch cast exception at runtime and try to add a default parse-processor in this cases. Hacky and bad for performance

Suggestions welcome.

[thomas-mc-work]

What about declaring a marker interface for data type conversion processors (like ParseInt). If there is none of them defined then automatically select a default one derived by the variable type (via BeanCellProcessorExtractor::mapFieldToDefaultProcessor()).

[dominikschlosser]

Changing processors is out of scope of this project since it is merely an addon to SuperCSV. But your suggestion is great anyway because there are already marker interfaces for primitive type conversions in the framework as far as i remember :-)

[thomas-mc-work]

Alright, sounds good. Otherwise you could not mark the processors (which makes sense that this is out of scope) but maybe the annotations, but your approach sounds more reasonable.