dominion525 / noto

Automatically exported from code.google.com/p/noto
0 stars 0 forks source link

Check name IDs for Vendor URL and Designer URL #342

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently we don't check those.  Historically Vendor URL was set to:

http://code.google.com/p/noto/

and Designer URL to:

http://www.monotype.com/studio

I think we should change the former to:

http://www.google.com/get/noto/

and also add check for both to nototools (and check for Adobe, and others, for 
non-Monotype fonts).

Original issue reported on code.google.com by behdad@google.com on 22 Apr 2015 at 12:00

GoogleCodeExporter commented 9 years ago
noto lint does check the Vendor URL, and checks to see that the designer url is 
not empty. 

I agree that it checks the wrong value for the Vendor url-- code.google.com is 
going away and we should use the get/noto url instead since presumably that is 
more stable.  The CJK fonts have Adobe as the Vendor for now, we passed on this 
for now so we could push out the update, but we need to discuss with them about 
changing it.

The Designer URL is whatever monotype wants it to be (for monotype).  Adobe 
left this empty in the CJK fonts, I think it would be better for them to 
provide one.  Again we want to discuss with them.

Original comment by dougf...@google.com on 22 Apr 2015 at 12:08

GoogleCodeExporter commented 9 years ago
Ah, thanks.  I was checking autofix_for_release instead of noto_lint.

We have a thread with Adobe trying to clean this up.

Original comment by beh...@chromium.org on 22 Apr 2015 at 12:32

GoogleCodeExporter commented 9 years ago
I have this already noted.

Original comment by ken.lu...@gmail.com on 22 Apr 2015 at 2:59

GoogleCodeExporter commented 9 years ago
The Noto Sans CJK fonts should now have the strings for name.ID=11 and 
name.ID=12 set correctly.

Original comment by ken.lu...@gmail.com on 23 Apr 2015 at 8:54

GoogleCodeExporter commented 9 years ago
The lint tool checks these, and confirms that the latest release from Adobe 
sets these names correctly.

Original comment by dougf...@google.com on 23 Apr 2015 at 11:13