dominion525 / noto

Automatically exported from code.google.com/p/noto
0 stars 0 forks source link

Code review request #363

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name: customize_lint

r05cd3261b188
r87b00af445ef
r41f0c3b7d886
r522c2fe331b3
r46c862ac9715

Purpose of code changes on this branch:

Change lint tool so a config file can be used to tailor what tests get run on a 
per-font basis.

This adds lint_config.py and lint_config.txt as the default config file it 
uses.  noto_lint.py now reads this file and builds a test configuration by 
default when running tests.

Noto lint can also pass overrides to the config on the command line so you can 
add/remove tests on the fly.

I added a flag to control every check noto lint performs, though in practice we 
probably won't need such full control.

When reviewing my code changes, please focus on: code

noto_lint still could use cleanup.  The two versions of name table checking for 
cjk and non-cjk is really crufty, I hacked that in so I could lint the Adobe 
font drop, but didn't it up as part of this.

The main feature I didn't add was the ability to custom values for particular 
tests to use.  This for example would let you override name table values, and 
potentially could move some of the tweaking done for the Adobe vs. Monotype 
differences to the config file.  We might use this, for example, if Monotype 
drops new versions of fonts under the new licence and we had to run the tool on 
a mix of new and old fonts for awhile.  I figured I'd wait on that and see how 
this works in practice first.

After the review, I'll merge this branch into:
/master

Original issue reported on code.google.com by dougf...@google.com on 9 May 2015 at 12:59