search

dominique-mueller / angular-notifier

A well designed, fully animated, highly customizable, and easy-to-use notification library for your Angular application.
https://www.npmjs.com/package/angular-notifier
MIT License
245 stars 67 forks source link

Add support for angular 7 #114

Closed keepframe closed 4 years ago

witek1902 commented 5 years ago

Any changes?

JoshuaNitschke commented 5 years ago

@witek1902

FYI I am using this in an Angular 7 app (that started out as a 6) and it seems to work fine, although I do get an NPM install warning.

npm WARN angular-notifier@4.1.1 requires a peer of @angular/common@>= 6.0.0 < 7.0.0 but none is installed. You must install peer dependencies yourself. npm WARN angular-notifier@4.1.1 requires a peer of @angular/core@>= 6.0.0 < 7.0.0 but none is installed. You must install peer dependencies yourself.

stefan-sesser commented 5 years ago

I also have the same problem as @JoshuaNitschke.

danner26 commented 5 years ago

If we could just get the deps updated it should work fine I believe.

Brachacz commented 5 years ago

Same here.

danner26 commented 5 years ago

Agreed

dominique-mueller commented 4 years ago

Fixed by #134, released as 5.0.0. Also note that #139 adds support for Angular 8, released as 6.0.0. Both releases do not contain any other breaking changes other than the Angular version. Enjoy!