search

dominique-mueller / angular-notifier

A well designed, fully animated, highly customizable, and easy-to-use notification library for your Angular application.
https://www.npmjs.com/package/angular-notifier
MIT License
245 stars 67 forks source link

fix(notifier): Fix circular dependency issues of injection tokens #124

Closed M4R1KU closed 4 years ago

M4R1KU commented 5 years ago

Resolves the circular dependency created when the injection tokens are imported in the notifier.service by extracting the tokens to their own file.

This especially caused problems with the new Ivy renderer in the Angular 8.0.0-beta.13.

codecov[bot] commented 5 years ago

Codecov Report

Merging #124 into develop will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #124      +/-   ##
===========================================
+ Coverage    99.13%   99.13%   +<.01%     
===========================================
  Files           14       15       +1     
  Lines          461      463       +2     
  Branches        79       79              
===========================================
+ Hits           457      459       +2     
  Misses           4        4
Impacted Files Coverage Δ
src/lib/src/notifier-token.ts 100% <100%> (ø)
src/lib/src/notifier.module.ts 100% <100%> (ø) :arrow_up:
src/lib/src/services/notifier.service.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1bff46d...8f2dba2. Read the comment docs.

dominique-mueller commented 4 years ago

Released with 4.1.2.