search

dominique-mueller / angular-notifier

A well designed, fully animated, highly customizable, and easy-to-use notification library for your Angular application.
https://www.npmjs.com/package/angular-notifier
MIT License
247 stars 68 forks source link

No notifications shown if one notification has been issued before ngOnInit #127

Closed snps-achim closed 5 years ago

snps-achim commented 5 years ago

I was debugging a situation where suddenly my notifications where not shown anymore in my Angular app. I have been by accident issuing a notification in my application initializer before the ngOnInit calls. As a result, no notifications where shown at all anymore.

In this case NotifierQueueService isActionInProgress is set to true before the NotifierContainerComponent has subscribed to the queueService.actionStream. As a result, no notifications will be shown due to NotifierQueueService tryToRunNextAction always skipping because of isActionInProgress evaluates to true always.

dominique-mueller commented 5 years ago

Fixed by #144.

dominique-mueller commented 5 years ago

Release with 6.0.1. Not that the 6.x releases of angular-notifier require an upgrade to Angular 8.