search

dominno / django-moderation

django-moderation is reusable application for Django framework, that allows to moderate any model objects.
BSD 3-Clause "New" or "Revised" License
269 stars 90 forks source link

Absolutely Insane !! #105

Closed djangoic closed 10 years ago

djangoic commented 10 years ago

Your package chooses to uninstall a django version without any warning. The requirements state this: python >= 2.4 django >= 1.3.X I had django 1.6.x installed and I tried a pip install for django-moderation.

If django-moderation is not compatible with django 1.6.x it should just stop from installing at the most, not uninstall and install an older version of django.

I am shocked, but this teaches me to be careful with doing pip install on the fly .. before looking at the setup.py. I have never found any django package daring to uninstall the base django version like this package did. This sucks !!!!

pip install django-moderation

Downloading/unpacking django-moderation Downloading django-moderation-0.3.4.tar.gz (42kB): 42kB downloaded Running setup.py egg_info for package django-moderation

Downloading/unpacking django>=1.3.7,<1.6 (from django-moderation) Downloading Django-1.5.8.tar.gz (8.1MB): 8.1MB downloaded Running setup.py egg_info for package django

warning: no previously-included files matching '__pycache__' found under dir                                                                             ectory '*'
warning: no previously-included files matching '*.py[co]' found under direct                                                                             ory '*'

Requirement already satisfied (use --upgrade to upgrade): setuptools in (from django-moderation) Installing collected packages: django-moderation, django Running setup.py install for django-moderation

Found existing installation: Django 1.6.1 Uninstalling Django: Successfully uninstalled Django Running setup.py install for django changing mode of build/scripts-2.7/django-admin.py from 664 to 775

warning: no previously-included files matching '__pycache__' found under dir                                                                             ectory '*'
warning: no previously-included files matching '*.py[co]' found under direct                                                                             ory '*'
changing mode of <path masked>/bin/django-admin.py to 775

Successfully installed django-moderation django Cleaning up...

bx2 commented 10 years ago

@djangoic I understand your frustration but if you are using virtualenv there is nothing simpler than to just re-install your desired version of the django package. You can do it with a single command: pip install django==1.6.x.

In the setup.py file there is an instruction that the django version should be >1.3 but <1.6 – this caused the unfortunate uninstall process. You could always post a pull request, so that the issue reported by you will be fixed faster – this is how it generally works.

Please remember that there is absolutely no guarantee on any open-source software and – what is more important – people on github are not your IT agency. If you decide to use the software offered for free here, we assume that you know what you are doing.

dominno commented 10 years ago

@djangoic Thanks to @Moustacha I just merged his PR that is adding support for django 1.6