Django 1.9 compatibility - Githubissues

dominno / django-moderation

django-moderation is reusable application for Django framework, that allows to moderate any model objects.

BSD 3-Clause "New" or "Revised" License

269 stars 90 forks source link

Django 1.9 compatibility #130

Closed phillipberndt closed 9 years ago

phillipberndt commented 9 years ago

This PR fixes any deprecation warning from Django 1.8. To run on 1.8, one also needs to include the changes from the PR by @bx2; I haven't fixed any of the <1.7 compatibility issues, so the automated tests will fail.

dominno commented 9 years ago

@phillipberndt Thank you for pull request. Unfortunately I will not merge anything if there are failing tests.

coveralls commented 9 years ago

Coverage decreased (-0.72%) to 91.36% when pulling 934561953facf2266bec7f77ea54b50506f8c987 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.72%) to 91.36% when pulling 934561953facf2266bec7f77ea54b50506f8c987 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.71%) to 91.37% when pulling dca05d9e31208b593f8c8515ca3c1e72be6582a5 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.71%) to 91.37% when pulling dca05d9e31208b593f8c8515ca3c1e72be6582a5 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.7%) to 91.38% when pulling 7780d8ec62304f806f6b689d698e558e7bb9d0a7 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.7%) to 91.38% when pulling 1f4d8a0677be4bbc932a806cb4834d43aa156c86 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-1.07%) to 91.01% when pulling 1829ee44225a65192d078c94ee8dd1d9ac27d921 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-1.07%) to 91.01% when pulling 1829ee44225a65192d078c94ee8dd1d9ac27d921 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-1.28%) to 90.8% when pulling fa3049f6ef3ab6983dc9d42222aed6c2c35d0bae on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-1.28%) to 90.8% when pulling fa3049f6ef3ab6983dc9d42222aed6c2c35d0bae on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

phillipberndt commented 9 years ago

All tests now pass for Django 1.8. I'll look into <=1.7 later..

coveralls commented 9 years ago

Coverage decreased (-0.87%) to 91.22% when pulling 30aefa54dc2dcc3dbc6167bf94a0bc802c2f6c5e on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.87%) to 91.22% when pulling 30aefa54dc2dcc3dbc6167bf94a0bc802c2f6c5e on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.1%) to 91.98% when pulling 23682d7b985f22aaa647f9ef8ca5eaf602f06781 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.1%) to 91.98% when pulling 23682d7b985f22aaa647f9ef8ca5eaf602f06781 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage increased (+0.14%) to 92.22% when pulling 333abb4cd8056527f22ce880ccbb2c4de4af7c5b on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage increased (+0.14%) to 92.22% when pulling 333abb4cd8056527f22ce880ccbb2c4de4af7c5b on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

phillipberndt commented 9 years ago

Fixing the tests required lots of changes. Most are cosmetic changes, but there are some important things. I'll add notes to the specific lines from the commits.

coveralls commented 9 years ago

Coverage decreased (-0.1%) to 91.98% when pulling 7918d9fc7c352abdc3bced0097eb5b8cb54b56f0 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.1%) to 91.98% when pulling 7918d9fc7c352abdc3bced0097eb5b8cb54b56f0 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.1%) to 91.98% when pulling 24af8bb6338fab1a99b31e01a1927fb65f4e6071 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.1%) to 91.98% when pulling 24af8bb6338fab1a99b31e01a1927fb65f4e6071 on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage increased (+0.14%) to 92.22% when pulling 6b4254c3047dc180b7af09f180002fa696190b8a on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage decreased (-0.08%) to 92.0% when pulling 6b4254c3047dc180b7af09f180002fa696190b8a on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage increased (+0.14%) to 92.22% when pulling 6b4254c3047dc180b7af09f180002fa696190b8a on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage increased (+0.14%) to 92.22% when pulling 6b4254c3047dc180b7af09f180002fa696190b8a on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

coveralls commented 9 years ago

Coverage increased (+0.14%) to 92.22% when pulling 6b4254c3047dc180b7af09f180002fa696190b8a on sapiu:fix-django18 into c219df48eff229a3a8b8e70965f1f2ee5244f962 on dominno:master.

phillipberndt commented 9 years ago

FYI, I tried to add Django 1.8 to the Travis config, but that doesn't work yet, apparently. It complains about something with django_webtest. I'll leave it to you to sort that out - the tests pass locally, and your constraint that no tests should fail with old versions is now fulfilled.

dominno commented 9 years ago

@phillipberndt Good job. Thank you