search

dominno / django-moderation

django-moderation is reusable application for Django framework, that allows to moderate any model objects.
BSD 3-Clause "New" or "Revised" License
269 stars 90 forks source link

Drop Django 2.2 #216

Closed MaybeThisIsRu closed 2 years ago

MaybeThisIsRu commented 2 years ago

Partially solves #214.

tox output:

  django3.1-py36: commands succeeded
  django3.1-py37: commands succeeded
  django3.1-py38: commands succeeded
  django3.1-py39: commands succeeded
  django3.2-py36: commands succeeded
  django3.2-py37: commands succeeded
  django3.2-py38: commands succeeded
  django3.2-py39: commands succeeded
  django3.2.9-py310: commands succeeded
  django4.0-py38: commands succeeded
  django4.0-py39: commands succeeded
  django4.0-py310: commands succeeded
  congratulations :)
DmytroLitvinov commented 2 years ago

Hi there,

Thank for you PR, but I don't see any problem right now to remove as classifier Django@2.2 and also strictly requires Django >= 3.1. There is no code modification in codebase where we need to drop Django@2.2 so while it works, I would leave it for now as it is.