Open daniel2013 opened 12 years ago
This sounds like it might be a bug with the implementation of fields_exclude
. Does moderation seem to work as expected when fields_exclude
is not present?
When commenting out fields_exclude the following happens:
Do you think you can fix this bug anytime soon?
I am not currently using django-moderation actively, so I may not look into this soon. Sorry.
I would make sure you are modifying the "unmoderated" object (the unapproved object in the moderation queue) when applying your changes rather than the "moderated" object (the approved object that does not have changes already made to it). Example 1 (this might be what's happening in your case):
a
a
and change a
again in a different waya
will be overwritten and replaced by the new ones (because you were modifying the already approved version of a
instead of the unmoderated version)Example 2:
a
a
and change a.moderated_object.changed_object
(this is the latest version of a
which may not be moderated yet)a
and your second changes are both queued for moderation (and are now in a.moderated_object.changed_object
)If you're making your changes through a form, you can use a BaseModeratedObjectForm
to make sure you're changing the unmoderated version of the object (read the "Forms" section of the README file).
Hi,
I am using te following code to moderate my object:
Then I modify my object and the changes appear in the moderated object admin page.
But when I do:
All changes in the moderated object admin disappear/revert back.
Am I doing something wrong or this a bug? And how can I fix it?
Thanks.