Django 1.4 compat + extras

[EBNull]

This branch updates django-moderation to work on Django 1.4, and adds limited support for working with django-reversion.

[dominno]

All test runners are failing to run. Did you fixed tests also ?

$ bin/test-1.4 /Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/conf/init.py:75: DeprecationWarning: The ADMIN_MEDIA_PREFIX setting has been removed; use STATIC_URL instead. "use STATIC_URL instead.", DeprecationWarning) Traceback (most recent call last): File "bin/test-1.4", line 22, in djangorecipe.test.main('example_project.development', 'moderation') File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/eggs/djangorecipe-0.23.1-py2.6.egg/djangorecipe/test.py", line 17, in main management.execute_manager(settings, argv=argv) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/core/management/init.py", line 459, in execute_manager utility.execute() File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/core/management/init.py", line 382, in execute self.fetch_command(subcommand).run_from_argv(self.argv) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/core/management/commands/test.py", line 49, in run_from_argv super(Command, self).run_from_argv(argv) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/core/management/base.py", line 196, in run_from_argv self.execute(_args, _options.dict) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/core/management/base.py", line 232, in execute output = self.handle(_args, _options) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/core/management/commands/test.py", line 72, in handle failures = test_runner.run_tests(test_labels) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/test/simple.py", line 380, in run_tests suite = self.build_suite(test_labels, extra_tests) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/test/simple.py", line 264, in build_suite suite.addTest(build_suite(app)) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/test/simple.py", line 79, in build_suite test_module = get_tests(app_module) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/test/simple.py", line 36, in get_tests test_module = import_module('.'.join(prefix + [TEST_MODULE])) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.4/django/utils/importlib.py", line 35, in import_module import(name) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/src/moderation/tests/init.py", line 5, in from moderation.tests.unit.admin import * File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/src/moderation/tests/unit/admin.py", line 15, in from moderation.filterspecs import ContentTypeFilterSpec ImportError: cannot import name ContentTypeFilterSpec

[dominno]

$ bin/test-1.3 Traceback (most recent call last): File "bin/test-1.3", line 22, in djangorecipe.test.main('example_project.development', 'moderation') File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/eggs/djangorecipe-0.23.1-py2.6.egg/djangorecipe/test.py", line 17, in main management.execute_manager(settings, argv=argv) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.3/django/core/management/init.py", line 438, in execute_manager utility.execute() File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.3/django/core/management/init.py", line 379, in execute self.fetch_command(subcommand).run_from_argv(self.argv) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.3/django/core/management/base.py", line 191, in run_from_argv self.execute(_args, _options.dict) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.3/django/core/management/base.py", line 220, in execute output = self.handle(_args, _options) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.3/django/core/management/commands/test.py", line 37, in handle failures = test_runner.run_tests(test_labels) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.3/django/test/simple.py", line 358, in run_tests suite = self.build_suite(test_labels, extra_tests) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.3/django/test/simple.py", line 248, in build_suite suite.addTest(build_suite(app)) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.3/django/test/simple.py", line 77, in build_suite test_module = get_tests(app_module) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/parts/django-1.3/django/test/simple.py", line 35, in get_tests test_module = import('.'.join(app_path + [TEST_MODULE]), {}, {}, TEST_MODULE) File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/src/moderation/tests/init.py", line 5, in from moderation.tests.unit.admin import * File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/src/moderation/tests/unit/admin.py", line 3, in from moderation.admin import ModerationAdmin, approve_objects, reject_objects,\ File "/Users/MacBookPro/Documents/virtualenvs/dj-mod/app/django-moderation/src/moderation/admin.py", line 98, in from moderation.filterspecs import RegisteredContentTypeListFilter ImportError: cannot import name RegisteredContentTypeListFilter

[EBNull]

No, I haven't adjusted the tests. They need to be edited to import the correct FilterSpec or ListFilter depending on django version, etc.

[dominno]

So please adjust the tests and then i can merge your pull request. All tests must be green. Thank you

Wysłane z iPhone'a

Dnia 28 kwi 2012 o godz. 20:54 CBWhizreply@reply.github.com napisał(a):

No, I haven't adjusted the tests. They need to be edited to import the correct FilterSpec or ListFilter depending on django version, etc.

---

Reply to this email directly or view it on GitHub: https://github.com/dominno/django-moderation/pull/65#issuecomment-5399179

[dominno]

@CBWhiz Hi CBWhiz I would like to merge your pull request but the tests are not fixed. Could you please fix them and i can merge your PR then. Thank you.

[lukeman]

@dominno Are you planning on maintaining compatibility with Django 1.1 and 1.2 in future releases? Seems any users still targeting those versions of Django (which is a bad idea considering they no longer receive security updates) would be using pinned versions of the app.

[EBNull]

The project that I was using this for has been suspended for a bit. I do plan to get back to fixing this, at least making the tests for 1.4 pass, but I'm not sure if i'll ever get to < 1.4 test compatibility. This ticket is on the back of my mind though, I don't know when (if) I will complete it.

[EBNull]

Now that #66 is completed, i'm going to close this. Thanks @mlavin for completing the compatibility update.

As for the related features, I ended up not using them, and as such, they're a dead end. I no longer support overriding the default manager as it can cause a lot of pain.