search

dominno / django-moderation

django-moderation is reusable application for Django framework, that allows to moderate any model objects.
BSD 3-Clause "New" or "Revised" License
269 stars 91 forks source link

Post-moderation signal is sent the old instance #88

Closed adityar7 closed 10 years ago

adityar7 commented 10 years ago

The approve and reject methods in ModeratedObject send the content_object to the pre_moderation signal handler, but then the _moderate method updates the object. Thus, when the cached object is sent to the post_moderation signal handler, it doesn't reflect the saved object.

Surely the post_moderation signal handler should receive the "new" object.

adityar7 commented 10 years ago

Duplicate of #89. Bah, why does Github open a new issue when a pull request is sent.