search

domitry / elegans

Elegant 3D plots generator with WebGL.
http://elegans.readthedocs.org/
Other
59 stars 20 forks source link

Added orbit option to Stage and World to enable OrbitControls #12

Closed jlstevens closed 8 years ago

jlstevens commented 8 years ago

This pull request adds an option to enable OrbitControls as proposed in issue #11. To enable OrbitControls, you simply need to set orbit to false in the Stage options (or the World options if used directly).

I should note that this requires a more recent version of three.js than used by the demos listed in the README (r66). A recent version of three.js (r72) has been tested and seems to work nicely.

If you have any suggestions for further improvements I would be very happy to implement them!

domitry commented 8 years ago

Sorry for my delayed replay.

This pull-req is awesome! Thank you! BTW can you add a new example to examples/ ? I checked the new option on my local environment, but files under examples/ are substitutes for GUI-test.

jlstevens commented 8 years ago

I've made a few minor fixes and added examples/orbit.html based on the existing surface.html example. If there is anything else you would like to see improved, do let me know!

domitry commented 8 years ago

Thanks @jlstevens it looks perfect for me. BTW I can't spend time for the development of Elegans enough, so I added you to Collaborator. If you'd like to add more code push it by yourself !

jlstevens commented 8 years ago

I do have some outstanding prototypes for new features that just need cleaning up. I will continue to propose any larger additions as pull requests but it is nice to also have merge rights and a chance to make small fixes directly when necessary. :-)

Thank you very much!