search

domkm / optimus-sass

Sass/SCSS asset loader for Optimus
Eclipse Public License 1.0
6 stars 5 forks source link

Issue loading assets from an uberjar #1

Open andyparsons opened 9 years ago

andyparsons commented 9 years ago

Hello, it appears that optimus-sass only works in a local environment and not an uberjar build due to it's use of io/file instead of io/resource:

Please see: https://github.com/DomKM/optimus-sass/blob/master/src/optimus_sass/core.clj#L18

and the original issue logged against optimus: https://github.com/magnars/optimus/issues/35

domkm commented 9 years ago

Thanks for the report, @andyparsons. I deployed 0.1.0-SNAPSHOT with the io/file -> io/resource change. Give it a try and let me know if it solves your problems. Thanks!

andyparsons commented 9 years ago

Thanks for the quick fix. Looks good and I'll give it a try.

radhikalism commented 9 years ago

@DomKM,

This fix doesn't seem to work. existing-resource from Optimus already returns a resource URL, so passing it through io/resource again produces a type error. I'm not sure if you meant to remove the call to existing-resource, or if you want to delete the io/resource invocation.

Also, because a resource URL isn't a File, compile-file fails with IllegalArgumentException. Is that argument type hint necessary?

This worked for me, for loading from a file and also from a webjar: https://github.com/arbscht/optimus-sass/commit/b4181ddccc0ca88cef71cfd582450b46daa1072a

domkm commented 9 years ago

Thanks for trying and fixing this, @arbscht. Would you like to submit a PR?