Closed volrath closed 1 year ago
Ring request's :params were overwritten by ring-handler, which assoc its params in the request.
:params
ring-handler
assoc
This scenario might be a common one, specially if the user is using something like ring.middlewares.params.wrap-params, for example.
ring.middlewares.params.wrap-params
This PR makes sure silk :params are merged to any possible existing request's :params.
I wrote a test for it, let me know if it's enough or if I should test or improve anything else.
Closes #21
Hmm not sure why that failed. I ran lein dev locally and all test passed. I'm fairly new to Clojure, if you can give me a hint I'll fix it.
lein dev
done @DomKM
Ring request's
:params
were overwritten byring-handler
, whichassoc
its params in the request.This scenario might be a common one, specially if the user is using something like
ring.middlewares.params.wrap-params
, for example.This PR makes sure silk
:params
are merged to any possible existing request's:params
.I wrote a test for it, let me know if it's enough or if I should test or improve anything else.
Closes #21