search

domkm / silk

Routing for Clojure & ClojureScript
222 stars 13 forks source link

Cljx dependancy is leaking to user project #9

Closed Deraen closed 9 years ago

Deraen commented 9 years ago

Cljx plugin should probably be defined on :dev profile to prevent it being added to project dependencies.

https://github.com/lynaghk/cljx#installation

domkm commented 9 years ago

Thanks for the notification. I wonder why the other plugins aren't also dependencies.

Deraen commented 9 years ago

It's not the plugin directly but what the plugin does.

Cljx 0.4.0 adds the cljx dependency to the project and thus pom will contain dependency to it. 0.5.0 has some code to make sure the dependency is only added when running repl, but using :dev profile might still be a good idea.

https://github.com/lynaghk/cljx/blob/master/src/cljx/plugin.clj#L27

domkm commented 9 years ago

Thanks for the notification and explanation.