domoszlai / juicy-gcode

A lightweight SVG to GCode converter for maximal curve fitting
https://hackage.haskell.org/package/juicy-gcode
MIT License
110 stars 7 forks source link

Support G5 command #7

Closed domoszlai closed 4 years ago

domoszlai commented 4 years ago

G5 command is going to be supported by GRBL soon, would be nice to be able to generate those from juicy-gcode

https://github.com/terjeio/grblHAL/issues/30

domoszlai commented 4 years ago

A command line argument is added to the g5 branch: -b. When it presents, the beziers are generated as G5 commands instead of being interpolated by arcs.

ithinkido commented 4 years ago

I have just tried the new G5-branch on the attached file, The output only generates one small section of G05 command. This is the command that I used : juicy-gcode 2.svg -b -o 2.nc G5 test.zip In the master branch, I was able to use the same file and generated a good match with bi-arcs, so I think the file is ok. Am I missing something here ?

domoszlai commented 4 years ago

Oh, I forgot the recursive step... Could you try it again please?

ithinkido commented 4 years ago

That looks perfect ! Can we leave this open for a while, I still need to test this some more ( on real hardware )

domoszlai commented 4 years ago

I don't want to throw away this feature. It will be merged with master and released eventually. I wait a bit before that though, there might be some bugs popping out.

domoszlai commented 4 years ago

A small warning: you get upside down gcode unless you use -m

ithinkido commented 4 years ago

Ok , thanks for the warning.

ithinkido commented 4 years ago

a quick simulation Bezier G05

domoszlai commented 4 years ago

Nice! I close this issue now. The g5 branch will be merged to master and released, so the feature will be available later