domoticz / domoticz-android

Domoticz Client Application for Android Devices
104 stars 70 forks source link

GCM ID failure #563

Closed MSe-5-14 closed 4 years ago

MSe-5-14 commented 4 years ago

Describe the bug I'm trying to push the my Google cloud messaging Id to domoticz from my Android 10 device. The app crashes directly. I assume this is caused by GCM being no longer supported. This has been replaced by FCM. I read on the domoticz GitHub that they have replaced the API. Did you?

To Reproduce Steps to reproduce the behavior:

  1. Go to 'settings'
  2. Scroll down to 'notification settings'
  3. Click on 'Google Cloud Messaging ID'
  4. App crashes

Expected behavior I would expect my GCM ID to be added to my domoticz. This doesn't happen.

Screenshots !!! If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Additional context https://github.com/domoticz/domoticz/issues/3292 https://developers.google.com/cloud-messaging/faq

galadril commented 4 years ago

Really weird, as we already use FCM btw (its only called gcm in the domoticz web uit).

MSe-5-14 commented 4 years ago

I tried it on 2 other Android 10 devices and I have the same issue.

galadril commented 4 years ago

Fyi i found the issue.. im working on a fix for it

image

Its not about the FCM implementation, but it's how i get a unique id for you device.. thats not allowed in Android 10 anymore (woops)..

galadril commented 4 years ago

I have a fix, its getting late here. Ill push a new mobile app version tomorrow.

MSe-5-14 commented 4 years ago

Great to hear. thanks for your time and good night :)

galadril commented 4 years ago

ive pushed a update to the play store, let me know when its working correctly (and close this issue)

MSe-5-14 commented 4 years ago

Thanks, this resolved the issue.