search

dompdf / php-font-lib

A library to read, parse, export and make subsets of different types of font files.
GNU Lesser General Public License v2.1
1.73k stars 256 forks source link

Update .gitattributes and remove bower.json + .htaccess #125

Closed williamdes closed 6 months ago

williamdes commented 8 months ago

Should I delete the file too? The htaccess does nothing, delete also?

williamdes commented 8 months ago

Last question: should the composer.json namespace be updated? Or only the homepage field?

bsweeney commented 8 months ago

I think you're fine to delete those files. I was trying to decide the best time to update the namespace. I'm about ready to release a new version of Dompdf so I guess now would be a good time for it?

williamdes commented 8 months ago

Yes definitely, I will not be on my workstation until this evening Feel free to do the changes in the mean time and close this one Can you give me some time to have a last check on my side that everything is ready for Debian too? Maybe I have one more change to do, not very sure about it

williamdes commented 8 months ago

I think I am all done here

I removed one config param that is not used in phpunit since a long time (Author says: https://stackoverflow.com/a/44331140/5155484)

williamdes commented 8 months ago

Why does composer say this lib is LGPL 3.0 and the LICENSE file says it is 2.1 ?

Should it be LGPL-2.1-or-later (https://spdx.org/licenses/) ?

Changed in https://github.com/dompdf/php-font-lib/pull/126