Final patch of optimizations, giving additional 20% speedup

dompdf / php-font-lib

A library to read, parse, export and make subsets of different types of font files.

GNU Lesser General Public License v2.1

1.74k stars 253 forks source link

Final patch of optimizations, giving additional 20% speedup #36

Closed indreka closed 8 years ago

indreka commented 8 years ago

This should be the last part of the parsing optimizations, overall speedup on my machine (Win10, PHP 5.5) for loading FreeSerif font is now ~55%, 1.3s => 0.65s.

PhenX commented 8 years ago

Great ! I didn't think inlining or passing as arguments could be so helpful. I see you like optimization, do you know blackfire.io ? I've been using it and it's really great.

indreka commented 8 years ago

I haven't used that, but it looks interesting :)

indreka commented 8 years ago

Hm, you closed this without merging. Was there some issue with the changes I suggested?

PhenX commented 8 years ago

Whoops sorry

indreka commented 8 years ago

Awesome :) I'm also sending some patches into Dompdf, hoping to achieve same level of optimization there also :)