Closed helmutschneider closed 2 years ago
While this fixed the issue I was initially having, it causes a few SVGs to render incorrectly.
Take these two SVGs as an example: car.txt people.txt
Here's what the people one should look like
And here's what it renders as with these changes
Interesting that it's specifically the top-left arc that is drawn incorrectly. Are both examples rendered using this library?
Interesting that it's specifically the top-left arc that is drawn incorrectly. Are both examples rendered using this library?
Through dompdf, yes. Without this PR I was getting the same error as was mentioned in #11 on one of my SVGs, but with it, so far three of my SVGs have been drawn incorrectly.
Update: I have since found a couple more SVGs that break. key.txt camera.txt
Both of these seem to behave differently from the last two.
Thanks - that is good news because we're probably looking at another parsing incompatibility. I will look into it during the weekend.
@liam-milbel Ok, have another go now
@liam-milbel Ok, have another go now
Looks good!
Hi @helmutschneider, @liam-milbel,
Thank you for this pull request!
Does it provide a fix or partial fix for #62 please?
Best wishes, Nick
@nfreear I don't know, feel free to test it.
Fixes #11 and dompdf/dompdf#1301. The logic is borrowed from fabric.js.