search

domsson / succade

Run, feed and style your Lemonbar with ease
Creative Commons Zero v1.0 Universal
55 stars 3 forks source link

String handling and buffers are a buggy, fragile mess and will break eventually #9

Closed domsson closed 6 years ago

domsson commented 6 years ago

Looking at the code after a while, I noticed that all the string handling is a hot mess. There is lots of "let's say this will never be longer than x chars" code that creates buffers of random, hardcoded size, then goes on to stuff more into those buffers than they can actually hold. It's a miracle we haven't seen any segfaults from this so far. Go ahead an refactor this before it blows up in someone's face!

domsson commented 6 years ago

All of these issues should be fixed as of 36ace83.