domstolene / da-otel-agent

This project delivers an OpenTelemetry Java Agent extension with a dynamically configurable sampler, along with the optional REST service for configuring it.
Apache License 2.0
12 stars 1 forks source link

Read only state should not change if left unspecified in a POST/PUT request #21

Closed turesheim closed 1 year ago

turesheim commented 1 year ago

Manually posting a configuration change while leaving the readOnly flag unspecified will result in the default value (true) being used, resulting in an unintended change. Since the client application will use the latest configuration from the service, it will also soon be synced. Restarting the service will remove all configurations, but they will also soon be synchronized from the client. Changing the client configuration from file will not help as the service configuration has been set read only.

There must be a way of trusting the configuration file change so that the client can override the configuration the service holds even if it is set to read only. But only if the configuration file is more recent than the service configuration timestamp.