search

domtronn / all-the-icons.el

A utility package to collect various Icon Fonts and propertize them within Emacs.
MIT License
1.48k stars 177 forks source link

[SVG] All the alists are not availables #370

Closed thierryvolpiatto closed 1 year ago

thierryvolpiatto commented 1 year ago

For my helm-all-the-icons package that allows showing all the icons available, now many are missing because some alists are empty:

(defvar helm-all-the-icons-alist '((all-the-icons-data-alltheicons-alist . all-the-icons-alltheicon)
                                   (all-the-icons-data-fa-icon-alist . all-the-icons-faicon)
                                   (all-the-icons-data-file-icon-alist . all-the-icons-fileicon)
                                   (all-the-icons-data-octicons-alist . all-the-icons-octicon)
                                   (all-the-icons-data-material-icons-alist . all-the-icons-material)
                                   (all-the-icons-data-weather-icons-alist . all-the-icons-wicon)))

Now only three alists are available whereas in master all are available. For reference: https://github.com/emacs-helm/helm-all-the-icons

wyuenho commented 1 year ago

You are reaching directly into undocumented alist variables instead of the public all-the-icons-[icon set]-data functions.

You need to rewrite helm-all-the-icons-sources. Take a look at this and this.

thierryvolpiatto commented 1 year ago

Jimmy Yuen Ho Wong @.***> writes:

You are reaching directly into undocumented alist variables instead of the public all-the-icons-[icon set]-data functions.

You need to rewrite helm-all-the-icons-sources. Take a look at this and this.

Ah! ok, I will look at this as soon as possible.

Thanks.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.*Message ID: @.***>

-- Thierry

thierryvolpiatto commented 1 year ago

Jimmy Yuen Ho Wong @.***> writes:

You need to rewrite helm-all-the-icons-sources.

Ok, done. Unfortunately you have removed all-the-icons-font-families so now I have to hardcode it, could you provide it again?

Thanks.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.*Message ID: @.***>

-- Thierry

wyuenho commented 1 year ago

There's all-the-icons-sets :)

thierryvolpiatto commented 1 year ago

Jimmy Yuen Ho Wong @.***> writes:

There's all-the-icons-sets :)

Great thanks, maybe add a defvaralias would be nice?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.*Message ID: @.***>

-- Thierry

wyuenho commented 1 year ago

@thierryvolpiatto 47e0cb99f2ebf11f4c8e6d9ab32e2be695bf3aaf

thierryvolpiatto commented 1 year ago

Thanks.