search

domtronn / magit-gh-issues.el

A small plugin for Magit which allows users to see, open, comment and label GitHub issues.
GNU General Public License v2.0
5 stars 1 forks source link

Currently this package also displays Pull Requests #39

Open domtronn opened 9 years ago

domtronn commented 9 years ago

I'm not sure whether or not this actually is an issue. GitHub treats all Pull Requests as issues practically... And this package should hopefully allow users to comment on, label and assign users to the Pull Requests, the only thing missing is the ability to actually merge the PR.

But this doesn't feel like the responsibilty of this package.

My question is, should they be displayed along side issues? And if so, should there be some visual indicator that they are PRs?

AlexChesters commented 9 years ago

FWIW I think they should be displayed alongside issues.

The Github docs state the following:

As far as the API is concerned, every pull request is an issue, but not every issue is a pull request.

I think there should be a visual indicator to indicate they are PRs. In ghi this is done with an arrow (see below):

158: WIP: Pulls 4 ↑
152: Proposal: Max columns at 80 1
domtronn commented 9 years ago

I've had a brief look into this, and whilst the GitHub API for Issues provides a pull_request block iff the issue is a pull request, gh.el doesn't deserialize the pull_request block into the issue object...

Soo, from our point of view, there's no meta data on the objects to indicate it's a PR. Perhaps it's worth looking at adding this information to gh.el as a boolean flag like pull-p?

AlexChesters commented 9 years ago

Hmm, that's disappointing! Yeah that solution seems sensible.