domtronn / nuzlocke.app

Nuzlocke Tracker - For all Pokémon games and Rom Hacks to record, track, advise on encounters, and provide boss battles & level caps
https://nuzlocke.app
BSD 3-Clause "New" or "Revised" License
107 stars 17 forks source link

Ruby/Sapphire Correctness Issues #142

Open stevedor opened 1 year ago

stevedor commented 1 year ago

Describe the bug The route data appears to be built around Emerald, and contains some inaccuracies for Ruby and Sapphire.

To Reproduce "Reproduction" is starting a new Ruby or Sapphire game and confirming that there are routes/areas that aren't accessible or pokemon data that is incorrect. See the list below.

Expected behavior Data should be consistent with what's possible in the games

This issue is core to the data in the application, but: Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context A few examples:

Debatable Inaccuracies:

stevedor commented 1 year ago

Some of these changes are actually preset in the data; however, they are not reflected on https://nuzlocke.app/. I'm not sure if that's just an older deployment of the application or if there's something else going on.

stevedor commented 1 year ago

I am working on a fix, but it looks like I need to modify the JSON directly. Is there a way to access the .txt files mentioned in the README? I don't see them in the project.

Also, I'm having some issues running the application on my end. Yarn is failing to install pokemon-assets 0.6.0 (404 not found). I tried 0.7.0 but it claims to be getting a malformed response. I'll keep an eye on it and see if either of these issues resolves so I can test my changes before submitting a PR.

gr3ger commented 1 year ago

I am working on a fix, but it looks like I need to modify the JSON directly. Is there a way to access the .txt files mentioned in the README? I don't see them in the project.

Is this what you're looking for?