search

domtronn / project-owl

Chrome extension for leaving commentings on pages
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Pin viewport sizes & associate comments to a viewport #1

Open domtronn opened 3 years ago

domtronn commented 3 years ago

Initial thoughts - capture a tag of device type when creating a thread and then manually filter bubbles by device type from the popup

Could filter bubbles by media query??

domtronn commented 3 years ago

Can modify the page width using the Chrome windows API

chrome.windows.getCurrent(({ id }) => {
  chrome.windows.update(id, { width: bubble.pageWidth }) 
  // or
  chrome.windows.update(id, { width: closestBreakPoint(bubble.pageWidth) }) 
})

Some questions around UX, i.e. whether or not it should pop up a new window or modify the current one or whether we invest in the chrome debugger api. My initial thought is to go new window

domtronn commented 3 years ago

There's also this I found on emulation https://github.com/paulirish/emulation-popup-ext/blob/master/app/scripts/background.js