domtronn / spaceline-all-the-icons.el

A Spaceline Mode Line theme using All The Icons for Emacs
MIT License
235 stars 25 forks source link

Clock Icon should only be included in Fullscreen Frames #12

Closed domtronn closed 7 years ago

domtronn commented 7 years ago

(Quoted from @jwintz #7)

the clock icon: I used to use your fonts, with the awesome all-the-icons in my previous setup in various places but since I didn't plan on getting weather forecast in my editor, I skipped the weather once. Now it is fixed, and I have my beautiful clock, however, I think this segment should only be display when the current frame is fullscreen.

domtronn commented 7 years ago

I'm not sure why you would want this behaviour? Would you mind adding some justification for this? Is it more that you would only want the clock when in you only have one window horizontally?

I mean, I can always add some kind of custom variable/setting for this 🤔

jwintz commented 7 years ago

No, my point is that this information is redundant with any desktop environment (which always displays current time), whenever emacs is not fullscreen. However, with a fullscreen emacs, the desktop environment panels are not visible anymore ;-)

domtronn commented 7 years ago

Ah! That's a very good point 😅 However, on my mac I have the "Automatically hide and show the menu bar" enabled, so even when Emacs isn't fullscreen I can't see the time!

screen shot 2017-04-21 at 12 24 36

But yep, that's a good enough reason for me to make this a customisable feature, I'll start working on this now 👍

jwintz commented 7 years ago

Awesome :-)

jwintz commented 7 years ago

Works like a charm, whenever used with the spaceline-all-the-icons-fullscreen segment. The behaviour is random using MacOS maximise button.

jwintz commented 7 years ago

Actually, using the MacOS green traffic light button, the behaviour is inversed (clock shows on minimize, disappears on maximize).

domtronn commented 7 years ago

Hmm, I can't reproduce this behaviour with the traffic light button? Is this still an issue?