search

domtronn / spaceline-all-the-icons.el

A Spaceline Mode Line theme using All The Icons for Emacs
MIT License
234 stars 24 forks source link

Huge powerline height by default #3

Closed bricewge closed 7 years ago

bricewge commented 7 years ago

By default the powerline-height is set to 22 on spacemacs. Setting it back to 1 solve this but if this theme would have a good default for it this will be great. screen shot 2017-04-14 at 10 11 21

domtronn commented 7 years ago

Powerline doesn't set a height by default (see here). However, it seems like Spacemacs does...

Looks like I had a different understanding for what powerline-height means 😅 I saw it as a scaling factor, i.e. a value of 2 would double the size of the mode line.

And it looks like when propertizing a text's height, the behaviour changes based on whether the value is an integer/float. When given a float (which is what I do for all my segments) it will scale the size of the font based on the size of the underlying font face (which all inherit from default font size) as documented here. Unfortunately, this means we're both right!

Buuuut, there is a variable called powerline-text-scale-factor which seems to be the intended version of what I want so I'm going to swap over to using that.