search

domtronn / spaceline-all-the-icons.el

A Spaceline Mode Line theme using All The Icons for Emacs
MIT License
235 stars 25 forks source link

Time is displayed, but not date #42

Closed publicimageltd closed 7 years ago

publicimageltd commented 7 years ago

I hope I am not missing something obvious, but I am unable to display the date in the modeline. I have turned on display-time-mode:

(display-time-mode 1)
(setq display-time-day-and-date t)

...but all I see is the time. Am I missing something obvious? Other themes (like powerline-default-theme) display the date nicely.

domtronn commented 7 years ago

Hey @publicimageltd, Just had a brief look at this and found that the way Powerline handles the time stuff is through the global-mode-string - This is a list of variables that take global precedence in the mode line! And enabling display-time-mode adds display-time-string to those list of variables.

However, the segment in spaceline-all-the-icons just uses the format-time-string function but it would be much better if it used the display-time-string when present!

I'll add this in when I get some time 👍

domtronn commented 7 years ago

@publicimageltd This should now be available in version 1.3.3 of the package, give it a bit of time to build up to Melpa but it should be there by the end of the day :)

publicimageltd commented 7 years ago

Thank you, both for the fast reply and the patch!

publicimageltd commented 7 years ago

Finally installed the new version. O how beautiful, it even has a nice icon! :-) Perfect!

domtronn commented 7 years ago

Haha, glad you like it! I'd be remiss if I don't add in icons anywhere and everywhere possible!

If you have any other suggestions or ideas, please feel free to raise more issues or PRs :)