domtronn / spaceline-all-the-icons.el

A Spaceline Mode Line theme using All The Icons for Emacs
MIT License
235 stars 25 forks source link

battery face #45

Closed mclearc closed 7 years ago

mclearc commented 7 years ago

I'd like the fancy-battery face to use different colors than the default (I'm using the solarized color theme). The following worked for my old spaceline cofig:

 (use-package fancy-battery
    :init 
    (fancy-battery-mode)
    :config
    (setq-default battery-update-interval 10)
    (set-face-attribute 'fancy-battery-charging nil 
    :foreground "dark blue" :weight 'bold)
    (set-face-attribute 'fancy-battery-discharging nil 
    :foreground "dark magenta" :weight 'bold)
    (set-face-attribute 'fancy-battery-critical nil 
    :foreground "dark red" :weight 'bold))

But this doesn't seem to be working with spaceline-all-the-icons. Any ideas?

domtronn commented 7 years ago

Hey! I didn't realise that fancy-battery exposed it's own faces, makes complete sense 🙂

By default, the just inherit from the faces I chose to use anyway! So I've refactored this to inherit from these faces instead. Once this gets built, this should hopefully fix it for you.

If you could try out the new version and report back, that would be great! Thanks

mclearc commented 7 years ago

Great - that works. Thanks for the package and the quick response!