search

domtronn / spaceline-all-the-icons.el

A Spaceline Mode Line theme using All The Icons for Emacs
MIT License
235 stars 25 forks source link

nyan-mode segment #48

Closed pqhieu closed 7 years ago

pqhieu commented 7 years ago

Hi,

First, thank you for the work. This mode line theme is awesome! However I didn't see any nyan-mode segment in the source code. Is it currently not supported?

Do you have any plans to include a nyan-mode segment into this theme any time soon?

Cheers,

domtronn commented 7 years ago

Hey! It's not a segment I use personally so I probably just never got round to adding it 😅 If it's something you'd like, I'm more than happy to add one in? In that case I can convert this issue into a feature request

pqhieu commented 7 years ago

Wow, thanks a lot, I would be more than happy if it's added. Keep up the good work!

domtronn commented 7 years ago

@pqhieu I've just pushed a version of spaceline-all-the-icons with the lovely nyan cat segment back in! 👍

It's enabled by default if you have nyan-mode on and will appear in the centre of the mode line, let me know if you have any troubles with it or would like anything different! 🙂

pqhieu commented 7 years ago

@domtronn Thanks for the work. It's working great!

However I think I found a bug in your code that causes Emacs to spew lots of Invalid face reference messages. You can check the *Messages* buffer when performing cursor movement to see it. See my PR for the fix.

Another thing I would like to see is to have a separator at the right hand side of the nyan segment. Since without it I don't know where is the end of the buffer. Here is an comparison with spaceline.

screen shot 2017-07-10 at 10 36 46 pm

and yours (see that I'm at the end of the buffer but the cat is not, lol).

screen shot 2017-07-11 at 1 22 15 am

I have also made some modifications to add a new separator at the end of nyan segment to make it look like this

screen shot 2017-07-11 at 1 32 09 am

What do you think? I'm not good with styling, so this is just a quick fix. If you're interested then I will create a PR.

Cheers,

domtronn commented 7 years ago

Yep! Very much see your point about having Nyan cat delimited by something so you can tell where abouts in the buffer you are! I've updated the segment to reflect your designs - Just there are some nuances around showing/not showing it so hopefully it'll be to your liking 🙂

And I'm sorry, but in that commit I fixed the invalid face property as well! 😅 Thanks a lot for the PR though, I do appreciate any bug fixes and things you find and definitely welcome PRs.

pqhieu commented 7 years ago

Hey I just tried your fixes. Seems good to me. Thanks a lot for the works!

I will close this issue for now.