search

domtronn / spaceline-all-the-icons.el

A Spaceline Mode Line theme using All The Icons for Emacs
MIT License
235 stars 25 forks source link

Add support for eyebrowse #56

Closed drrlvn closed 6 years ago

drrlvn commented 7 years ago

Like in spaceline: https://github.com/TheBB/spaceline#eyebrowse

domtronn commented 7 years ago

Hi @spatz, I don't personally use Eyebrowse so I'm not sure how it's meant to behave or how you'd like it represented in the modeline. I also have an issue open for Perspective as well (#14) which feels very similar.

I can just port over the spaceline code if you want, but if there's any extra features/functionality you'd like out of it let me know 👍

drrlvn commented 7 years ago

Porting the spaceline code would be great, nothing more needed as far as I'm concerned. Thanks!

domtronn commented 7 years ago
screen shot 2017-08-24 at 11 09 18

I've started porting this over, and adding a little bit of iconization to the mode line (see screenshot). Workspace number 2 called foobar. What do you think?

I was going to make the displaying of the workspace name customisable/optional with spaceline-all-the-icons-eyebrowse-display-name.

Also, I've got it reusing the same icon set for window-numbering which you can see as it's eyebrowse window config 2 but I'm active in window 1... Would you prefer to have a separate icon set for eyebrowse compared to window-number? Do you use both of them at the same time?

Lastly, should the eyebrowse appear in all windows, or just active ones?

drrlvn commented 7 years ago

I do use both at the same time. I think they should be separately customizable but it's fine if the default is the same.

In spaceline the window number and window config number are shown as n/m or n|m (window, separator, window config) which I think is intuitive. You can show the name after or replace the window config number by the name if it's shown.

It should appear in all windows IMO.

domtronn commented 7 years ago
screen shot 2017-08-24 at 11 38 06

Cool, I've implemented all of that - Separate icons, reformatted to have the slot number first, then the workspace name :)

Also, the eye icon works as a button to create a new workspace, you can also switch workspace by clicking on the number/name... I know people are unlikely to use a mouse but still nice 👍

If you're happy, I'll release a new version with this in?

drrlvn commented 7 years ago

Looks awesome! Thanks!