domtronn / spaceline-all-the-icons.el

A Spaceline Mode Line theme using All The Icons for Emacs
MIT License
235 stars 25 forks source link

Clock shown when maximized, should only be when "fullboth" #71

Open andersjohansson opened 6 years ago

andersjohansson commented 6 years ago

The test whether the clock should be shown uses the the fullscreen frame parameter. This can however be non-nil with several values that I don’t think should be considered fullscreen in the sense of hiding everything. From info page:

‘fullscreen’ This parameter specifies whether to maximize the frame’s width, height or both. Its value can be ‘fullwidth’, ‘fullheight’, ‘fullboth’, or ‘maximized’. A “fullwidth” frame is as wide as possible, a “fullheight” frame is as tall as possible, and a “fullboth” frame is both as wide and as tall as possible. A “maximized” frame is like a “fullboth” frame, except that it usually keeps its title bar and the buttons for resizing and closing the frame. Also, maximized frames typically avoid hiding any task bar or panels displayed on the desktop. A “fullboth” frame, on the other hand, usually omits the title bar and occupies the entire available screen space.

Thus I believe the case where the clock should be shown is when Emacs hides the top panel of my desktop environment (I use gnome), which only happens with fullboth (I don’t know if the behaviour is any different for example on mac). The test should be: (eq (frame-parameter nil 'fullscreen) 'fullboth)

Thanks for a nice package!