search

domtronn / spaceline-all-the-icons.el

A Spaceline Mode Line theme using All The Icons for Emacs
MIT License
235 stars 25 forks source link

Two of the segment names in the readme, don't match their symbol names #80

Open duianto opened 6 years ago

duianto commented 6 years ago

The https://github.com/domtronn/spaceline-all-the-icons.el#icon-sets section, indicates that one can change the icon sets for a segment by replacing modified in the line:

(setq spaceline-all-the-icons-icon-set-modified 'toggle)

with the segment names in the table. But eyebrowse-workspace and multiple-cursors do not work, because the names don't match the symbol names that are defined here: https://github.com/domtronn/spaceline-all-the-icons.el/blob/e2e195f64a541d72b6d0ba0451f1e3072234b820/spaceline-all-the-icons-segments.el#L143 and https://github.com/domtronn/spaceline-all-the-icons.el/blob/e2e195f64a541d72b6d0ba0451f1e3072234b820/spaceline-all-the-icons-segments.el#L256

I don't know if the names in the readme should be renamed, or if the symbol names should be changed.

PS: I just remembered that the toggle segment commands use the names:

spaceline-toggle-all-the-icons-eyebrowse-workspace
spaceline-toggle-all-the-icons-eyebrowse-workspace-on
spaceline-toggle-all-the-icons-eyebrowse-workspace-off

and

spaceline-toggle-all-the-icons-multiple-cursors
spaceline-toggle-all-the-icons-multiple-cursors-on
spaceline-toggle-all-the-icons-multiple-cursors-off

so for consistency, maybe the symbol names should be changed.