Spaceline doesn't show file name in certain themes?

domtronn / spaceline-all-the-icons.el

A Spaceline Mode Line theme using All The Icons for Emacs

MIT License

235 stars 25 forks source link

Spaceline doesn't show file name in certain themes? #93

Open zzantares opened 5 years ago

zzantares commented 5 years ago

Hi! I've been using this package for quite some time and it's great, however under certain themes the spaceline doesn't show the name of the file, here's a screenshot, you can see it just draws a black box where the name goes.

I experience this effect with the kaolin-themes. I don't think this is an issue, but I wanted to ask what is the face I need to change to fix this? how could I know this myself? Should I discuss this in the kaolin theme's github?

Thanks for any help!

ogdenwebb commented 5 years ago

I'm not sure that's bug related to my package, but I found a workaround for this issue and push new faces for powerline/spaceline mode-line to master, which should fix the problem. Please test it.

Presumably the problem causes when background in spaceline faces is nil, for example.

(spaceline-highlight-face (:background nil :foreground "#68f3ca"))

Looks like a spaceline segment/separator uses background from the default face as fallback instead of background color from mode-line face in this case.

zzantares commented 5 years ago

Hi @ogdenwebb, thanks for looking into it! I've pulled the changes but it still doesn't show the filename, now it looks like this:

However, if I disable the highlighting option (setq spaceline-all-the-icons-highlight-file-name nil), it does show the filename:

Or perhaps, is something wrong in my configuration? Although I have only changed the size, you can see my settings here.