domvwt / esparto

Data driven report builder for the Python data ecosystem.
MIT License
85 stars 7 forks source link

Add support for Python 3.11 #130

Closed eric-rm closed 1 year ago

eric-rm commented 1 year ago

In Python 3.11 the dataclass default mutability check raises ValueError for any unhashable default (https://docs.python.org/3/whatsnew/3.11.html#dataclasses). With default_factory we get unique instances for each OutputOptions.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 :tada:

Comparison is base (7a3106f) 91.98% compared to head (8323d19) 92.09%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #130 +/- ## =========================================== + Coverage 91.98% 92.09% +0.11% =========================================== Files 9 10 +1 Lines 923 936 +13 Branches 142 160 +18 =========================================== + Hits 849 862 +13 Misses 52 52 Partials 22 22 ``` | [Impacted Files](https://app.codecov.io/gh/domvwt/esparto/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dom) | Coverage Δ | | |---|---|---| | [esparto/\_options.py](https://app.codecov.io/gh/domvwt/esparto/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dom#diff-ZXNwYXJ0by9fb3B0aW9ucy5weQ==) | `84.62% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/domvwt/esparto/pull/130/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dom)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

domvwt commented 1 year ago

@eric-rm: thank you for your contribution - I'll try to review sometime this week