domyd / mlp

A Dolby TrueHD demuxer and utility tool, with a focus on accurate and correct TrueHD demuxing.
Apache License 2.0
64 stars 2 forks source link

Baywatch BD/UHD -> "please file issue" #3

Open wowdeathbringer opened 4 years ago

wowdeathbringer commented 4 years ago

Hi @domyd ,

when I try to demux the TrueHD stream from the extended version of "Baywatch" (2017), the summary states "please file issue". This happens for the Blu-ray and UHD alike.

Baywatch_BD Baywatch_UHD

Since this is the movie I first recognized the problem and got the issue started with LAVFilters, I would have expected it to have to remove some part of the audio at almost each segment change, but it only did so once. Please let me know if you need further information to investigate this.

domyd commented 4 years ago

Can you re-run it with -vv and post the output?

Tip: if you run it in powershell, you can do

mlp ... -vv > output.txt

to write the log to a file instead of to the console.

wowdeathbringer commented 4 years ago

Here're the logfiles: Baywatch_BD_Extended_output.txt Baywatch_UHD_Extended_output.txt

domyd commented 4 years ago

Thanks!

That's a very interesting disc. I've looked at the segment boundaries and 13/15 don't match at all. 1 of them is a perfect match, and that was removed. And the last one is actually a match, but the audio is offset by about 4 samples:

image

Looks like I'm going to have to get this disc to figure out what's going on there.

wowdeathbringer commented 4 years ago

I imported it from Italy (https://www.amazon.it/Baywatch-Blu-Ray-4K-UltraHD/dp/B072FP6TBN/), but I guess the UHD disc is the same in Germany / Austria, since there's a german audio track on it. The Blu-ray in that package does not have german audio, so there might be some differences if you get a Version from Germany or Austria.

Just in case, I also made logfiles from the cinematic version. When I checked all the branching points in a muxed MKV, I did not encounter any problems with the cinematic version. So this might be interesting as well. Baywatch_UHD_Cinematic_output.txt Baywatch_BD_Cinematic_output.txt

dastardo commented 4 years ago

I have the same issue with Apocalypse Now (UHD), it has 26 segments.

image host

dastardo commented 4 years ago

Here is the full log file:

Apocalypse.Now.Theatrical.UHD.txt

domyd commented 4 years ago

Thanks! I'll be taking a look at that disc as well.

dastardo commented 4 years ago

Thanks! I'll be taking a look at that disc as well.

It's the 2 in 1 disc, I completed the muxing process and there were noticeable breaks in the audio

dastardo commented 4 years ago

@domyd I've just tried Cars UHD which has 95 segments and has noticable breaks in the THD during playback from a file made with MakeMKV. All is good! Here is the log if you would like to have a look:

Cars UHD.txt

domyd commented 4 years ago

Sorry, are you saying you have issues with the Cars THD generated with mlp, or are you confirming that it works as advertised?

dastardo commented 4 years ago

All is good! It worked perfectly with no errors!

dastardo commented 4 years ago

I just tried Midway UHD and it's way out. Midway.UHD.txt

jackjonez666 commented 4 years ago

Please file issue --> "Knives out" U.S. UHD:

00945.mpls, 2:10:13 [506+502+505+504+503].m2ts

knives.txt

dastardo commented 4 years ago

Both Midway and Knives Out are Lionsgate discs with obfuscated playlists and Screenpass

domyd commented 4 years ago

I get the same output for my Knives Out disc. That's really odd, it looks like the A/V sync should be a good half second off around the middle of the movie. Thanks for reporting it, I'll see what's going on there.

@dastardo What does that obfuscation look like? Can you give me some more info on that?

dastardo commented 4 years ago

Obfuscation as in the file is broken into segments and they also add a fake playlist to try and add further confusion.

dastardo commented 3 years ago

Another one for you @domyd Are you still looking into this issue? It's Resident Evil Apocalypse

REA.txt

domyd commented 3 years ago

Thanks for the report. I haven't gotten around to figuring these out yet, hoping to do that soon™ ... I'm also running low on disk space 😄

domyd commented 3 years ago

I've investigated the Knives Out issue, and it seems that mlp indeed produces bad output for that disk (and presumably for all "please file issue" disks). The TrueHD streams are actually about 1000 samples shorter than the video segments, according to ffmpeg. But, MakeMKV somehow magically finds the missing audio (and it is legit, it's not just copied to fill the length or something) and gets a correct demux. So for now, until I get to the bottom of this, I'd suggest using MakeMKV for disks where it says "please file issue" at the end.

dastardo commented 3 years ago

Good to know you're still looking into it @domyd. I have been using DGDemux as I find it is much better than MakeMKV. I quite often get dropouts and sync issues with MakeMKV whereas I don't get as many issues with DGDemux, Cars demuxed with MakeMKV is terrible with constant breaks and dropouts.

Interestingly even DGDemux cannot achieve a correct demux for Apocalypse Now or Resident Evil Apocalypse. DGDemux is successful with Knives Out and Midway though. If you need any samples from DGDemux just let me know.

videoh commented 3 years ago

dastardo, can you explain the issue with DGDemux and Apocalypse Now or Resident Evil Apocalypse? I can have a look at that and try to fix it.

dastardo commented 3 years ago

@videoh There are breaks in the TrueHD and it goes out of sync, IIRC it only happens on the extended version of Resident Evil Apocalypse, it's a 2 in 1 disc but the theatrical version seems to be OK. I believe both the theatrical and redux versions of Apocalypse Now have the issue, it is also a 2 in 1 disc.

videoh commented 3 years ago

Thank you. How far out of sync does it get by the end? I will get Apocalypse Now and see if I can duplicate the issue. Is that the bluray or UHD version I should get?

dastardo commented 3 years ago

I would guess it goes a good couple of seconds out of sync so you will definitely notice it. You need the UHD 2 in 1 disc which has the theatrical and redux versions. There is also another UHD disc which is the final cut only, there are no issues with that disc.

videoh commented 3 years ago

I cannot find an Apocalypse Now UHD 2-in-1 with theatrical and redux on amazon or elsewhere. I can only find the Final Cut. Can you give a link to purchase it?

videoh commented 3 years ago

I bought the 6-disk UHD set. Apparently, it has the versions we need.

dastardo commented 3 years ago

Nice work @videoh! I guess you work on developing DGDemux?

videoh commented 3 years ago

He he, I am DG.

dastardo commented 3 years ago

Thank you for all your hard work! It's a great piece of software!

Could you please reply on this thread if you manage to fix it?

videoh commented 3 years ago

Of course I will. domy's github has been open in my browser for months. :)

And thank you for your kind words.

videoh commented 3 years ago

So I got the 6-disk UHD set. Disk 2 is the "1979 Original" UHD. I ripped it with MakeMKV, extracted the video and THD streams with DGDemux, and muxed them to an MKV with mkvtoolnix. The resulting file played with reasonable sync throughout (not perfect but reasonable). It certainly is not a couple seconds out at any point. The playlist has 25 gaps, so at 0.8ms per frame that is only 20ms that could be attributed to DGDemux gap correction. So apparently I still don't have the disk that you are experiencing problems with. If you can't link me to a place to purchase it, I don't see how I can help with it.

dastardo commented 3 years ago

Is there any way I can message you @videoh?

videoh commented 3 years ago

My email addie is on this page:

http://rationalqm.us/

videoh commented 3 years ago

Still not seeing any issues with your disk. Please explain your process that leads you to a couple seconds out of sync.

videoh commented 3 years ago

In email, we established that this is not a DGDemux issue, but rather a player issue.

dastardo commented 3 years ago

It appears to be a Plex issue on the Shield which only happens with 2 in 1 discs. I have found a work around by using the Plex add on for Kodi then setting the playercorefactory.xml file to use VLC player. When using VLC for playback there are no breaks or sync issues.

toni-do commented 3 years ago

truehd is definitely the source of the dropout issues but there is also an issue with the mkv container.

decrypted uhd iso => makemkv/mkvtoolnix => movie.mkv played on oppo: dropouts decrypted uhd iso => tsmuxer => movie.m2ts played on oppo: ok

decrypted uhd iso => mlp: "please file issue" movie.m2ts => mlp: "perfect"

movie.m2ts => mkvtoolnix => movie.mkv played on oppo: dropouts

remuxing a working m2ts into mkv should work. i think it is related to this issue: https://gitlab.com/mbunkus/mkvtoolnix/-/issues/3027

m2ts has some disadvantages but is the only solution right now. btw: tsmuxer cannot fix broken streams. you need to create the m2ts directly from the decrypted disc/iso.