search

don-tnowe / godot-inspector-extender

Using just comments, add specialized inspectors for your Godot 4 scripts.
MIT License
97 stars 8 forks source link

somehow deletes nodes or crashes editor with some tool scripts #2

Closed Lodugh closed 1 year ago

Lodugh commented 1 year ago

You can replicate the issue in this demo: https://github.com/expressobits/inventory-system-demos The bug happens when the plugin is enabled and I have an inventory node selected(in a scene that owns it) and I switch the scene tab. Then sometimes the inventory node gets deleted or the editor just crashes. Theres no @@ used in the comments, so that shouldnt be an issue. Only error that it spits out when it happens: editor/editor_data.cpp:1066 - Condition "!p_node->is_inside_tree()" is true

don-tnowe commented 1 year ago

So THAT what it was when I was working on my project. Thanks for finding a reproduction!

In my case it happened only with tool scripts. Seems to be the case with this demo too, other nodes aren't deleted.

Must be the workaround related to non-tool scripts not having certain properties/methods in the editor. I'll try to address this now

don-tnowe commented 1 year ago

Fixed, also please let me know if @@resource_table works with custom/addon classes.