search

don-tnowe / godot-resources-as-sheets-plugin

I needed to edit many Resource files, so figured someone would too.
MIT License
433 stars 19 forks source link

Preloaded script constants may conflict with global classes #28

Closed pmorim closed 1 year ago

pmorim commented 1 year ago

Is this plugin compatible with Godot 4.1? I'm just getting an empty UI and some console errors when opening the tab.

image

don-tnowe commented 1 year ago

Should be, because I just used it on 4.1.0 yesterday :/

Will check on the latest-latest stable. Thank you a lot for providing the error messages!

don-tnowe commented 1 year ago

Update: can't reproduce.

I assume Godot hasn't guessed a property's type because there's a cyclic dependency, and one script hasn't loaded. Does it happen if every script in addons/resources_spreadsheet_view/main_sceen/ is opened then saved (Ctrl+S) then closed?

I have an idea on how to make it consistent, but just checkin'.

pmorim commented 1 year ago

After some extra investigating, I found that the issue was that I already had a SelectionManager autoload conflicting with the one from this plugin.

Maybe prefix all of the class_names with the plugin name to reduce the possibility of conflicts? Or are there any other solutions?

don-tnowe commented 1 year ago

Uhhhhhh there are no class_names. That is, most scripts that absolutely need to use that keyword are already prefixed - others are preloaded in constants WHICH IN TURN causes the conflicts, yeah.

Good catch! I can rename them, but would prefer to look for other options first 🤔