search

don-tnowe / godot-sprite-painter

Image editor right inside Godot 4.
MIT License
83 stars 8 forks source link

4.1 upgrade + Little fix #14

Closed TigranExe closed 1 year ago

TigranExe commented 1 year ago

This branch includes:

  1. The automatic Godot 4.1 adjustments Godot makes.
  2. a fix to the following error: An error kept appearing that stated an invalid substraction in type_context_settings between a "Vector2i" and "Vector2" was occuring. Upon looking, the last of the 3 times the readjust_size() function is called on, get_parent().size is of type Vector2i.

This doesn't solve the crashing or the errors in setting type_context_settings's editor_plugin but that will have to be looked into. Let me know thoughts!

don-tnowe commented 1 year ago

Looks clean. I would take issue in auto-updating or formatting files in a PR, but I would need to do that anyway, so thanks.

I didn't get that error when working, but I see this could trouble some folks. The goal is no errors at all. Thank you for the Fix!

This made me notice there's an ImageTexture stuck in that scene file, I'll remove it now.