don-tnowe / godot-sprite-painter

Image editor right inside Godot 4.
MIT License
79 stars 8 forks source link

Add a Settings menu and/or extend tool settings #7

Open don-tnowe opened 1 year ago

don-tnowe commented 1 year ago

There are things that should be configurable. A Settings menu is mandatory in software, and Sprite Painter does not have one.

Possible settings:

Feel free to suggest more configurable things!

seafiish commented 1 year ago

If you're going to have it, I believe the crosshair should be by default 2 (or similarly low), and have an exported slider for if you would like to extend the length to use it as a ruler.

My argument for having it low by default it's very distracting and different (I've never seen it before in any other raster editor), and while I think the idea is certainly interesting and might be useful in some situations, I think more often than not it is not worth the distraction.

Regarding having the long crosshair in general, I don't want to try to convince you to remove it entirely, but I would like to voice a concern I have with it.

I worry that by the time you're zoomed out far enough to actually see the entire crosshair comfortably, you're not really worried about single-pixel details. If you're already zoomed out this far, like 98% of the time you'll be using the brush.

image

And when you're closer to the level of zoom you would have when using the pencil, it just gets in the way of seeing the pixels you care about. You may argue this is the point, but you're already more than close enough to generally tell when pixels are on the same axis.

image

Regarding all the other tools that use the straight crosshair (Box and Color Selection, Shape and Line tools), it just serves to distract you. Pixel alignment is either irrelevant or the tool already gives you straight edges. And by the time you're zoomed out enough to use these tools comfortably, the ruler becomes unnecessary.

How often do I really need to know if a particular pixel is the exact x as this other particular pixel when I'm at this zoom level?

image

But I don't want to just complain. Time to make suggestions.

I feel a separate, toggle ruler overlay tool would much better accomplish your goal. It would provide a ruler the length of the whole canvas, and it wouldn't be there when you don't need it to be.

To conclude, I want to make it very clear that I don't want to impose any opinions on your project. I just would love to see this project grow and want to voice my concern about this. I can't wait to hear your counter-arguments and thoughts!