search

don-tnowe / godot-sprite-painter

Image editor right inside Godot 4.
MIT License
83 stars 8 forks source link

Notify user when an SVG file is edited and resaved as PNG #8

Open seafiish opened 1 year ago

seafiish commented 1 year ago

Since it's possible to open and draw on files that you can't actually edit (e.g. SVG), there should either be: 1) a clear warning put up when you open such a file in the editor, 2) all the tools should be grayed out/locked, 3) or being able to open such files should be entirely removed.

I'd be happy to implement this myself if you're willing to bear with the time it will take me (as I'm new to Godot), just let me know which you prefer or if you have other ideas (also which filetypes that don't work).

don-tnowe commented 1 year ago

Actually, it is possible to open them. Kinda. Just saves it as .png in the same folder when you try (thanks for reporting last time, that's what made me fix this)

At one point, I thought of implementing proper SVG editing support. Simple raster editors are good for pixelart but some people despise it, or just prefer vector after working in Flash (yes there are still people making games in Flash) Also would mean I get to not touch Inkscape again.

But that would take lots of time because of a completely different toolset needed, plus programming in the performant SVG rendering

seafiish commented 1 year ago

Oh! Good to know, perhaps we should document this and / or add a note when in svg files?

don-tnowe commented 1 year ago

Likely. I'll need to think how to better inform the user.

DearFox commented 7 months ago

I just accidentally lost a file because the plugin overwrote a png with the same name when opening an svg. Even though I didn't save it. I think it would be nice to have something for file security.

DearFox commented 7 months ago

I just accidentally lost a file because the plugin overwrote a png with the same name when opening an svg. Even though I didn't save it. I think it would be nice to have something for file security.

Yes, when you click on the Discard button, the plugin still saves the file, apparently.