don-tnowe / godot-sprite-painter

Image editor right inside Godot 4.
MIT License
84 stars 8 forks source link

Add palette support #9

Open seafiish opened 1 year ago

seafiish commented 1 year ago

This would be best done after https://github.com/don-tnowe/godot-sprite-painter/issues/7, so that you could implement saving and loading different palettes via settings, unless you wanted to implement it differently.

Using a palette loading method that is supported by Lospec.com would be wise impo

don-tnowe commented 1 year ago

Palette colors could be added in the color picker... if the interference with the editor's other places that use a color picker don't bother you. Though I agree a separate panel would be better.

Lospec import sound easy, just paste the link, append .json and do a GET.

seafiish commented 1 year ago

Aseprite has great palette support if you need implementation ideas!

Uhhh, that might work I guess, but I don't think that's how you're supposed to do it. I was referring to how Lospec lets you download palettes in a number of formats like .png or a .HEX file. You would just need to decide which download method(s) you want to support for the way palette's are loaded/saved.

image Here's an example of a 8x png download, that something like Aseprite can pull the colors from and save as a palette: image

don-tnowe commented 1 year ago

You don't think? That's literally their web API. Downloading a file manually is an unneeded extra step

seafiish commented 1 year ago

I'm sorry, I believe I've offended you.

This is my first time trying to help with a project. My year and a half of experience so far was all in theory learning- I'm only just starting to dive into practical coding. I'm trying my darnedest to help and provide input because I love this project and want to help it flourish in whatever direction you go with it, but I'm out of my element here.

If I'm stepping on your toes or being a nuisance I truly apologize, I'm just trying to help in any way I can. So please, if I'm doing open source contribution wrong in some way or am just not helping here, maybe we can take this conversation to Discord and we can talk about how I can be a benefit to this project.

God bless :)