don-tnowe / godot-worldmap-builder

Build skill trees and level selection screens in Godot 4.
MIT License
69 stars 4 forks source link

Allow user to quickly change node data on currently selected node with a select option #10

Open Piotr-Aueternum opened 1 month ago

Piotr-Aueternum commented 1 month ago

Proposal as the next iteration of #9 which is much more convenient option to change nodes. I think that feature could be later adopted in Adding new nodes with [+] button around the circle.

Context: Currently I'm working on Passive Skill Tree that will have 100s of nodes I found it a little difficult to change them one by one in WorldMapGraph/Path/Path Nodes while having to hover to see node index and to switch between pages

Scenario:

don-tnowe commented 1 month ago

Yeah, this is useful! It can actually be simpler: a popup list is already there if base_type is set, picking Resources of the type from the entire project with a search bar. The trick might be in raising awareness of this option, without adding an extra button because on my end the picker in your pull request is already quite small? The custom_minimum_size change didn't seem to work:

изображение

I will experiment with opening it when left-clicking the filename.

Piotr-Aueternum commented 1 month ago

You are right! prop_editor.base_type = 'WorldmapNodeData' in 'Quick Load' lists all available Resources of type. Do you think it is possible to trigger it on [Click] of resource name instead of the option in dropdown? Right now for some reason nothing happens when you click the resource name only the dropdown works.

I double checked the custom_min_size I'm using v4.3.stable.official [77dcf97d8]

don-tnowe commented 1 month ago

Do you think it is possible to trigger it on [Click] of resource name

No. And I just tried it: the Quick Load window immediately closes when the id_pressed signal is forcibly emitted. Another workaround would be needed, but I still managed to open the popup.