don-tnowe / godot-wyvernbox-inventory

Action RPG-focused inventory system for Godot 3 and 4
MIT License
105 stars 4 forks source link

Examples: some text relies on translations for string interpolation #17

Closed Basilicum closed 1 year ago

Basilicum commented 1 year ago

Hi! Getting into the Plugin blind is quite overwhelming and it'd really help to have a Demo Project to look into for reference.

Thanks for your time.

don-tnowe commented 1 year ago

There is one?

If you install the plugin without disabling the example/ folder, you get a 2D and 3D scene with all main features and some hint popups.

Basilicum commented 1 year ago

image

Huh, found it! Thanks, however it seems both the 2D and 3D Scene cause some sort of error. Even tried a blank new Project File...

don-tnowe commented 1 year ago

I'll need to fix that, yeah.

The translated string is supposed to have a "%s" to insert a number, but a new user won't have the translation files added. I'll probably make it a hard-coded string for the example.

Basilicum commented 1 year ago

Not entirely sure what you mean by that. Is there any quick fix I can do on my side?

don-tnowe commented 1 year ago

On toolbar, Project > Project Settings > Localization -> Add and add example/translation/ui.en.translation.

I'm quickly gonna update it so it's not gonna be needed.