search

don / node-eddystone-beacon

Create an Eddystone Beacon using Node.js https://github.com/google/eddystone
Other
315 stars 48 forks source link

Platform check is troublesome for websocket shim #23

Open jacobrosenthal opened 9 years ago

jacobrosenthal commented 9 years ago

Im developing a websocket version of bleno here. https://github.com/jacobrosenthal/bleno/tree/websocket

This platform check doesnt work in that scenario so Im not successfully advertising. https://github.com/don/node-eddystone-beacon/blob/master/lib/beacon.js#L128

Should bleno bindings return the underlying platform? or is there a way to push this check down into the bleno layer which better knows which bindings its using?

sandeepmistry commented 9 years ago

Should bleno bindings return the underlying platform?

That would be the simplest solution for now.

or is there a way to push this check down into the bleno layer which better knows which bindings its using?

It's a possibility, but this would involve the bleno layer parsing the EIR data, and removing the flags. All for an OS X quirk.