search

don9z / blackboard-theme

Port the color-theme-blackboard in emacs to it's own theming mechanism
49 stars 10 forks source link

Background is very deep bright blue on my machine #6

Open habibalamin opened 6 years ago

habibalamin commented 6 years ago

This is what I get on my machine.

emacs-blackboard-theme

As you can see, it's not exactly like the screenshot in the README. I am using GNU Emacs 25.3.1 (installed via Homebrew), and Terminal.app 2.8 (400) on High Sierra 10.13.3, but I also get the same result on iTerm2. I have tried both with and without tmux and my $TERM is screen-256color in tmux and xterm-256color outside of it.

adamcooper94 commented 5 years ago

Same issue, were you able to fix this?

adamcooper94 commented 5 years ago

Same issue, were you able to fix this?

habibalamin commented 5 years ago

I don't think I was, unfortunately. I just opted for a different theme.

AxelKrypton commented 5 years ago

I had the same issue and, after having had a look to the theme code, I think that the deep bright blue background is somehow intended. The responsible line

https://github.com/don9z/blackboard-theme/blob/7a0d79410feb728ff5cce75c140fadc19a3f9a6d/blackboard-theme.el#L33

can be changed to `(default ((t (:background "#000000" :foreground "#F8F8F8" )))) in order to obtain a black background.

Clearly, you need to reload the theme (e.g. reloading ~/.emacs file) in order to see the change.

Another needed change, in my opinion, is to make the highlight colors (e.g. used in the iedit mode), to make regions more recognizable. The default

https://github.com/don9z/blackboard-theme/blob/7a0d79410feb728ff5cce75c140fadc19a3f9a6d/blackboard-theme.el#L78

gives a very light grey background which is hard to immediately see on a black background. I set it to `(highlight ((t (:background "yellow" :foreground "black")))) to have black text on yellow background.

Finally, not needed and matter of taste, I also customized the comment color using red instead of grey, changing

https://github.com/don9z/blackboard-theme/blob/7a0d79410feb728ff5cce75c140fadc19a3f9a6d/blackboard-theme.el#L39

to `(font-lock-comment-face ((t (:italic t :foreground "#FF0000")))).