search

donald-jackson / kannel-pluginbox

Kannel Pluginbox allows users to implement their own business logic for routing, billing, etc in Kannel.
Other
12 stars 9 forks source link

DB support #8

Closed rkluwen closed 7 years ago

rkluwen commented 7 years ago

Donald, right now I've got a bunch of plugins, each with their own database support. Would that be something to integrate in the pluginbox core? Or add a gwlib extension to Kannel itself? Not sure what they way to go would be here.

rkluwen commented 7 years ago

I'm working on a proposal now, coming up in some pull-request-to-come.

rkluwen commented 7 years ago

See the dbsupport2 pull-request.

donald-jackson commented 7 years ago

No pull request received as yet. I just wanted to add, including db support in pluginbox core would not be desirable as some people use pluginbox for other filtering/http/non-db uses. I would prefer this contained in some plugin infrastructure

rkluwen commented 7 years ago

The pull request was already there... Just the issue was not closed yet. Using db support is purely optional of course.

donald-jackson commented 7 years ago

I'm not sure if I'm doing something stupid here, I see no pull requests/code etc anywhere on this issue or github page? :)

rkluwen commented 7 years ago

The pull request has already been merged as well.

donald-jackson commented 7 years ago

Apologies I was confusing the issues with the other one submitted. I'm getting old.