donaldzou / WGDashboard

Simple dashboard for WireGuard VPN written in Python & Vue.js
https://donaldzou.github.io/WGDashboard-Documentation/
Apache License 2.0
1.63k stars 252 forks source link

add spanish lang #423

Closed TheSL18 closed 1 week ago

donaldzou commented 3 weeks ago

@TheSL18 Hi! I left a comment in your commit, do you mind look over it please? Thank you!

TheSL18 commented 3 weeks ago

@TheSL18 Hi! I left a comment in your commit, do you mind look over it please? Thank you!

@donaldzou Hi, I don't see the comment...

donaldzou commented 3 weeks ago

That's weird lol

image

DaanSelen commented 2 weeks ago

That's weird lol

IMAGE FROM ABOVE (BUT ITS HUGE)

Does this also apply to the Dutch one now? I copied the German one as template.

DaanSelen commented 2 weeks ago

@TheSL18 is there something wrong? Your translations looked fine!

TheSL18 commented 2 weeks ago

Yeah, I made a rookie mistake, I didn't push the changes from the main repository and I got into a conflict one when I corrected my mistake, I'm merging all the changes to upload the new result.

TheSL18 commented 2 weeks ago

image Specifically this is the error

donaldzou commented 2 weeks ago

Hi @TheSL18 , just wondering in the Spanish JSON file.. you have these lines of translation included, but they don't appear in WGDashboard:

{
    "This settings will be kept inside your configuration file": "Estas configuraciones se mantendrán dentro de tu archivo de configuración",
    "Keep default / change it later": "Mantén el valor predeterminado / cámbialo más tarde",
    "Example": "Ejemplo",
    "Skip this section": "Omitir esta sección",
    "Port": "Puerto",
    "Connection Type": "Tipo de conexión",
    "Encryption": "Cifrado",
    "Strict Transport Security": "Seguridad estricta de transporte",
    "Enable": "Habilitar",
    "Disable": "Deshabilitar",
    "DNS over HTTPS": "DNS sobre HTTPS",
    "Timezone": "Zona horaria",
    "Login": "Iniciar sesión"
}

Just wondering where they apply to?

DaanSelen commented 2 weeks ago

I do love that commit message.

rcv11x commented 1 week ago

just yesterday i was going to make a new PR to add the spanish language, but i saw this user's PR. i hope it will be merged soon thanks 👍🏼

DaanSelen commented 1 week ago

@rcv11x @jpizquierdo if you want to overlook this and make sure you all agree? I do not speak Spanish so you all are better for that!

DaanSelen commented 1 week ago

Lang name must be english it has espanol twice

DaanSelen commented 1 week ago

I accidentally closed this branch which closed the PR. Wanting to merge it into 4.2-dev branch